Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wb single byte write behavior #23418

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Fix wb single byte write behavior #23418

merged 2 commits into from
Oct 3, 2024

Conversation

jukuisma
Copy link
Contributor

@jukuisma jukuisma commented Oct 1, 2024 •
edited
Loading

  • Mark this if you consider it ready to merge
  • I've added tests (optional)
  • I wrote some lines in the book (optional)

Description

Fix a bug in single byte wb commands and add some new test cases that catch the old bug. Related to: #23405, but doesn't implement the multibyte wb commands yet.

@jukuisma
Copy link
Contributor Author

jukuisma commented Oct 2, 2024 •
edited
Loading

TODO:

  • Update (neo)?vim configs to use tabs instead of spaces in C
  • Amend commit messages and write PR description
  • Use bitwise or instead of +=, which should also work now that the shifts have been fixed
  • Consider dropping the extra shift variable to make the function even more readable

@jukuisma
Add single byte wb test cases to reproduce a bug
453b74e 
Fix one previous false positive and add two new test cases for wb single
byte commands.
@jukuisma
Fix a bug in single byte wb commands
f4afd3a
@jukuisma jukuisma changed the title Draft: Fix wb single byte write behavior Fix wb single byte write behavior Oct 2, 2024
@trufae trufae merged commit 55a2c25 into radareorg:master Oct 3, 2024
42 checks passed
@trufae
Copy link
Collaborator

trufae commented Oct 3, 2024

Good catch and fix, TDD all the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jukuisma @trufae